chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js - Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Readd missing dep and add a new one that should've been there already. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js ('K') | « chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

index 2776b6f9f258bd456373611be8168bacd825b788..c33060899fe391dfc8a3de1b3118514e1d1a699b 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

@@ -18,15 +18,6 @@ goog.require('cursors.Cursor');

goog.require('cvox.ChromeVoxEditableTextBase');

goog.require('cvox.TabsApiHandler');

-// Define types here due to editable_text.js's implicit dependency with

-// ChromeVoxEventWatcher.

-/** @type {Object} */

-cvox.ChromeVoxEventWatcher;

-/** @type {function(boolean)} */

-cvox.ChromeVoxEventWatcher.handleTextChanged;

-/** @type {function()} */

-cvox.ChromeVoxEventWatcher.setUpTextHandler;

goog.scope(function() {

var AutomationNode = chrome.automation.AutomationNode;

var Dir = AutomationUtil.Dir;