chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs - Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs

Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Readd missing dep and add a new one that should've been there already. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js ('K') | « chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs

diff --git a/chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs b/chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs

index d22ae1eba8de37a3c4a44261833986849a82aa27..2df3086d66bf05e9131605f155dadd60af914f20 100644

--- a/chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs

+++ b/chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs

@@ -95,6 +95,7 @@ CvoxEditableTextUnitTest.prototype = {

/** @override */

closureModuleDeps: [

+ 'cvox.ChromeVoxEditableElement',

'cvox.ChromeVoxEditableHTMLInput',

'cvox.ChromeVoxEditableTextBase',

'cvox.ChromeVoxEventWatcher',

@@ -275,7 +276,7 @@ TEST_F('CvoxEditableTextUnitTest', 'Selection', function() {

TEST_F('CvoxEditableTextUnitTest', 'MultiLineText', function() {

var str = 'This string\nspans\nfive lines.\n \n';

var tts = new TestTts();

- var obj = new cvox.ChromeVoxEditableTextBase(str, 0, 0, false, tts);

+ var obj = new cvox.ChromeVoxEditableElement(null, str, 0, 0, false, tts);

obj.multiline = true;

obj.getLineIndex = function(index) {

if (index >= 33) {