Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Unified Diff: Source/core/svg/SVGElement.cpp

Issue 889563002: Make RenderObject::style() return a const object (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix a crashers (everything is building!) Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGElement.cpp
diff --git a/Source/core/svg/SVGElement.cpp b/Source/core/svg/SVGElement.cpp
index 0c28644a2127af181a58cfbc7358966f02de4526..2dab96a8cae4963ac164598c3a37a9c18a1a994e 100644
--- a/Source/core/svg/SVGElement.cpp
+++ b/Source/core/svg/SVGElement.cpp
@@ -909,7 +909,7 @@ PassRefPtr<RenderStyle> SVGElement::customStyleForRenderer()
if (!correspondingElement())
return document().ensureStyleResolver().styleForElement(this);
- RenderStyle* style = 0;
+ const RenderStyle* style = 0;
if (Element* parent = parentOrShadowHostElement()) {
if (RenderObject* renderer = parent->renderer())
style = renderer->style();
@@ -944,7 +944,7 @@ RenderStyle* SVGElement::computedStyle(PseudoId pseudoElementSpecifier)
RenderStyle* parentStyle = 0;
rune 2015/01/29 23:16:32 Can't parentStyle be const, style() used below, an
Julien - ping for review 2015/02/10 07:33:20 You're right. Done.
if (Element* parent = parentOrShadowHostElement()) {
if (RenderObject* renderer = parent->renderer())
- parentStyle = renderer->style();
+ parentStyle = renderer->deprecatedMutableStyle();
}
return svgRareData()->overrideComputedStyle(this, parentStyle);

Powered by Google App Engine
This is Rietveld 408576698