Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: Source/core/svg/SVGStopElement.cpp

Issue 889563002: Make RenderObject::style() return a const object (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix a crashers (everything is building!) Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGStopElement.cpp
diff --git a/Source/core/svg/SVGStopElement.cpp b/Source/core/svg/SVGStopElement.cpp
index 30d7abfc7dc88145876ee6e944622a9d5a73cc0c..aca2be0861b5fdd4e84b8a1b2814ebdc2270e83c 100644
--- a/Source/core/svg/SVGStopElement.cpp
+++ b/Source/core/svg/SVGStopElement.cpp
@@ -58,7 +58,7 @@ void SVGStopElement::svgAttributeChanged(const QualifiedName& attrName)
SVGElement::svgAttributeChanged(attrName);
}
-RenderObject* SVGStopElement::createRenderer(RenderStyle*)
+RenderObject* SVGStopElement::createRenderer(const RenderStyle*)
{
return new RenderSVGGradientStop(this);
}
@@ -70,7 +70,7 @@ bool SVGStopElement::rendererIsNeeded(const RenderStyle&)
Color SVGStopElement::stopColorIncludingOpacity() const
{
- RenderStyle* style = renderer() ? renderer()->style() : 0;
+ const RenderStyle* style = renderer() ? renderer()->style() : 0;
rune 2015/01/29 23:16:32 Does nullptr instead of 0 work here?
Julien - ping for review 2015/02/10 07:33:20 Done.
// FIXME: This check for null style exists to address Bug WK 90814, a rare crash condition in
// which the renderer or style is null. This entire class is scheduled for removal (Bug WK 86941)
// and we will tolerate this null check until then.

Powered by Google App Engine
This is Rietveld 408576698