Make RenderObject::style() return a const object

Source/core/svg/SVGElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Alp Toker <alp@atoker.com>
  * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 891 matching lines @@
         if (property && property->needsSynchronizeAttribute())
             property->synchronizeAttribute();
     }
 }
 
 PassRefPtr<RenderStyle> SVGElement::customStyleForRenderer()
 {
     if (!correspondingElement())
         return document().ensureStyleResolver().styleForElement(this);
 
-    RenderStyle* style = 0;
+    const RenderStyle* style = 0;
     if (Element* parent = parentOrShadowHostElement()) {
         if (RenderObject* renderer = parent->renderer())
             style = renderer->style();
     }
 
     return document().ensureStyleResolver().styleForElement(correspondingElement(), style, DisallowStyleSharing);
 }
 
 MutableStylePropertySet* SVGElement::animatedSMILStyleProperties() const
 {
@@ skipping 11 matching lines @@
 {
     if (hasSVGRareData())
         svgRareData()->setUseOverrideComputedStyle(value);
 }
 
 RenderStyle* SVGElement::computedStyle(PseudoId pseudoElementSpecifier)
 {
     if (!hasSVGRareData() || !svgRareData()->useOverrideComputedStyle())
         return Element::computedStyle(pseudoElementSpecifier);
 
     RenderStyle* parentStyle = 0;

[rune, 2015/01/29 23:16:32]

Can't parentStyle be const, style() used below, and overrideComputedStyle's
parentStyle parameter be made const?

[Julien - ping for review, 2015/02/10 07:33:20]

You're right. Done.

     if (Element* parent = parentOrShadowHostElement()) {
         if (RenderObject* renderer = parent->renderer())
-            parentStyle = renderer->style();
+            parentStyle = renderer->deprecatedMutableStyle();
     }
 
     return svgRareData()->overrideComputedStyle(this, parentStyle);
 }
 
 bool SVGElement::hasFocusEventListeners() const
 {
     return hasEventListeners(EventTypeNames::focusin) || hasEventListeners(EventTypeNames::focusout)
         || hasEventListeners(EventTypeNames::focus) || hasEventListeners(EventTypeNames::blur);
 }
@@ skipping 226 matching lines @@
     Element::trace(visitor);
 }
 
 const AtomicString& SVGElement::eventParameterName()
 {
     DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt", AtomicString::ConstructFromLiteral));
     return evtString;
 }
 
 } // namespace blink