Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 889343002: Added a test for icon attribute values with leading/trailing spaces. (Closed)

Created:
5 years, 10 months ago by pals
Modified:
5 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Added a test for icon attribute values with leading/trailing spaces. https://html.spec.whatwg.org/multipage/forms.html#attr-menuitem-icon "icon" attribute's value must contain a valid non-empty URL potentially surrounded by spaces. BUG=87553 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189323

Patch Set 1 #

Patch Set 2 : Added a comment to icon string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M LayoutTests/http/tests/misc/custom-context-menu.html View 3 chunks +7 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/misc/custom-context-menu-expected.txt View 2 chunks +3 lines, -2 lines 0 comments Download
M public/web/WebMenuItemInfo.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pals
Please review.
5 years, 10 months ago (2015-02-02 06:33:30 UTC) #2
tkent
lgtm
5 years, 10 months ago (2015-02-02 07:24:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889343002/20001
5 years, 10 months ago (2015-02-02 07:24:42 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 09:54:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189323

Powered by Google App Engine
This is Rietveld 408576698