public/web/WebMenuItemInfo.h - Issue 889343002: Added a test for icon attribute values with leading/trailing spaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebMenuItemInfo.h

Issue 889343002: Added a test for icon attribute values with leading/trailing spaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added a comment to icon string Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebMenuItemInfo.h

diff --git a/public/web/WebMenuItemInfo.h b/public/web/WebMenuItemInfo.h

index 11525bcf121bef836e50e9f0221c93eef89fa978..25180a89d2debded294ae184c7f31ca49979a278 100644

--- a/public/web/WebMenuItemInfo.h

+++ b/public/web/WebMenuItemInfo.h

@@ -58,6 +58,7 @@ struct WebMenuItemInfo {

}

WebString label;

+ // "icon" provides absolute URL of an image that repesents the command.

WebString icon;

WebString toolTip;

Type type;

« no previous file with comments | « LayoutTests/http/tests/misc/custom-context-menu-expected.txt ('k') | no next file » | no next file with comments »