Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: LayoutTests/http/tests/misc/custom-context-menu.html

Issue 889343002: Added a test for icon attribute values with leading/trailing spaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added a comment to icon string Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/http/tests/misc/custom-context-menu-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/misc/custom-context-menu.html
diff --git a/LayoutTests/http/tests/misc/custom-context-menu.html b/LayoutTests/http/tests/misc/custom-context-menu.html
index c1816bc3277c6060412041577c0de6d6b2bce34a..4c044096735683b0bf8566ce1e6055e68394cdd2 100644
--- a/LayoutTests/http/tests/misc/custom-context-menu.html
+++ b/LayoutTests/http/tests/misc/custom-context-menu.html
@@ -59,8 +59,10 @@
<menuitem type="radio" radiogroup="group" label="Item17"></menuitem>
<menuitem type="radio" radiogroup="group" label="Item18" checked></menuitem>
<menuitem type="radio" radiogroup="group" label="Item19"></menuitem>
- <!-- Test menuitem of with "icon" attribute. -->
- <menuitem label="Item20" icon="abc.png" checked></menuitem>
+ <!-- Test menuitem with "icon" attribute. -->
+ <menuitem label="Item20" icon="icon1.png" checked></menuitem>
+ <!-- Test menuitem with "icon" attribute having leading and trailing white spaces. -->
+ <menuitem label="Item21" icon=" icon2.png " checked></menuitem>
<!-- Test removal of separator at the end. -->
<hr>
</menu>
@@ -166,7 +168,7 @@ eventSender.keyDown("escape");
var button5 = document.getElementById("button_5");
var items5 = contextClickAndGetMenuItems(button5);
-shouldBeEqualToNumber("itemsWithCustomContextMenu.length - items.length", 24);
+shouldBeEqualToNumber("itemsWithCustomContextMenu.length - items.length", 25);
shouldBeEqualToString("itemsWithCustomContextMenu[0]", "Item1");
shouldBeEqualToString("itemsWithCustomContextMenu[1]", "#Item2");
shouldBeEqualToString("itemsWithCustomContextMenu[2]", "---------");
@@ -190,7 +192,8 @@ shouldBeEqualToString("itemsWithCustomContextMenu[19]", "Item16");
shouldBeEqualToString("itemsWithCustomContextMenu[20]", "Item17");
shouldBeEqualToString("itemsWithCustomContextMenu[21]", "*Item18");
shouldBeEqualToString("itemsWithCustomContextMenu[22]", "Item19");
-shouldBeEqualToString("itemsWithCustomContextMenu[23]", "Item20http://127.0.0.1:8000/misc/abc.png");
+shouldBeEqualToString("itemsWithCustomContextMenu[23]", "Item20http://127.0.0.1:8000/misc/icon1.png");
+shouldBeEqualToString("itemsWithCustomContextMenu[24]", "Item21http://127.0.0.1:8000/misc/icon2.png");
shouldBeEqualToNumber("items1.length - items.length", 0);
shouldBeEqualToNumber("items2.length - items.length", 0);
shouldBeEqualToNumber("items3.length - items.length", 0);
« no previous file with comments | « no previous file | LayoutTests/http/tests/misc/custom-context-menu-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698