Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 888983002: Dont set NEEDS_OFFLINE_PROCESSING flag. (Closed)

Created:
5 years, 10 months ago by Rune Fevang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dont set NEEDS_OFFLINE_PROCESSING flag. The server will now always do processing for nodes that don't have stars.id set, so no need to flip this flag any more. BUG= Committed: https://crrev.com/846191e5a12945951960c39b43ec33ee5d35cfba Cr-Commit-Position: refs/heads/master@{#314900}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -115 lines) Patch
M components/enhanced_bookmarks/enhanced_bookmark_model.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model.cc View 1 5 chunks +0 lines, -28 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc View 1 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Rune Fevang
5 years, 10 months ago (2015-01-30 21:53:33 UTC) #2
noyau (Ping after 24h)
lgtm
5 years, 10 months ago (2015-02-05 17:51:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888983002/1
5 years, 10 months ago (2015-02-05 17:51:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/20977) mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/31088)
5 years, 10 months ago (2015-02-05 17:54:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888983002/20001
5 years, 10 months ago (2015-02-05 21:27:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 22:24:48 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 22:25:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/846191e5a12945951960c39b43ec33ee5d35cfba
Cr-Commit-Position: refs/heads/master@{#314900}

Powered by Google App Engine
This is Rietveld 408576698