Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc

Issue 888983002: Dont set NEEDS_OFFLINE_PROCESSING flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/enhanced_bookmarks/enhanced_bookmark_model.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc
diff --git a/components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc b/components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc
index 3f4517bc4699a4fda9eea3d239f7e6592c31c4cd..4b53abdf35c0cc647f0a0947bed9edcb3c4afe7f 100644
--- a/components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc
+++ b/components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc
@@ -679,85 +679,6 @@ TEST_F(EnhancedBookmarkModelTest, NodeRemovedWhileResetDuplicationScheduled) {
base::RunLoop().RunUntilIdle();
}
-// Verifies that the NEEDS_OFFLINE_PROCESSING flag is set for nodes added
-// with no remote id.
-TEST_F(EnhancedBookmarkModelTest, BookmarkAddedSetsOfflineProcessingFlag) {
- const BookmarkNode* node =
- bookmark_model_->AddURL(bookmark_model_->other_node(),
- 0,
- base::ASCIIToUTF16("Some title"),
- GURL(BOOKMARK_URL));
- std::string flags_str;
- EXPECT_FALSE(node->GetMetaInfo("stars.flags", &flags_str));
- base::RunLoop().RunUntilIdle();
- ASSERT_TRUE(node->GetMetaInfo("stars.flags", &flags_str));
- int flags;
- ASSERT_TRUE(base::StringToInt(flags_str, &flags));
- EXPECT_EQ(1, (flags & 1));
-}
-
-// Verifies that the NEEDS_OFFLINE_PROCESSING_FLAG is not set for added folders.
-TEST_F(EnhancedBookmarkModelTest, FolderAddedDoesNotSetOfflineProcessingFlag) {
- const BookmarkNode* node = AddFolder();
- base::RunLoop().RunUntilIdle();
-
- std::string flags_str;
- if (node->GetMetaInfo("stars.flags", &flags_str)) {
- int flags;
- ASSERT_TRUE(base::StringToInt(flags_str, &flags));
- EXPECT_EQ(0, (flags & 1));
- }
-}
-
-// Verifies that when a bookmark is added that has a remote id, the status of
-// the NEEDS_OFFLINE_PROCESSING flag doesn't change.
-TEST_F(EnhancedBookmarkModelTest,
- BookmarkAddedWithIdKeepsOfflineProcessingFlag) {
- BookmarkNode::MetaInfoMap meta_info;
- meta_info["stars.id"] = "some_id";
- meta_info["stars.flags"] = "1";
-
- const BookmarkNode* node1 =
- bookmark_model_->AddURLWithCreationTimeAndMetaInfo(
- bookmark_model_->other_node(),
- 0,
- base::ASCIIToUTF16("Some title"),
- GURL(BOOKMARK_URL),
- base::Time::Now(),
- &meta_info);
- base::RunLoop().RunUntilIdle();
- std::string flags_str;
- ASSERT_TRUE(node1->GetMetaInfo("stars.flags", &flags_str));
- int flags;
- ASSERT_TRUE(base::StringToInt(flags_str, &flags));
- EXPECT_EQ(1, (flags & 1));
-
- meta_info["stars.flags"] = "0";
- const BookmarkNode* node2 =
- bookmark_model_->AddURLWithCreationTimeAndMetaInfo(
- bookmark_model_->other_node(),
- 0,
- base::ASCIIToUTF16("Some title"),
- GURL(BOOKMARK_URL),
- base::Time::Now(),
- &meta_info);
- base::RunLoop().RunUntilIdle();
- ASSERT_TRUE(node2->GetMetaInfo("stars.flags", &flags_str));
- ASSERT_TRUE(base::StringToInt(flags_str, &flags));
- EXPECT_EQ(0, (flags & 1));
-}
-
-TEST_F(EnhancedBookmarkModelTest,
- NodeRemovedWhileSetNeedsOfflineProcessingIsScheduled) {
- const BookmarkNode* node =
- bookmark_model_->AddURL(bookmark_model_->other_node(),
- 0,
- base::ASCIIToUTF16("Some title"),
- GURL(BOOKMARK_URL));
- bookmark_model_->Remove(node->parent(), node->parent()->GetIndexOf(node));
- base::RunLoop().RunUntilIdle();
-}
-
TEST_F(EnhancedBookmarkModelTest,
RemoveParentShouldRemoveChildrenFromMaps) {
const BookmarkNode* parent = AddFolder();
« no previous file with comments | « components/enhanced_bookmarks/enhanced_bookmark_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698