Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: components/enhanced_bookmarks/enhanced_bookmark_model.cc

Issue 888983002: Dont set NEEDS_OFFLINE_PROCESSING flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/enhanced_bookmarks/enhanced_bookmark_model.cc
diff --git a/components/enhanced_bookmarks/enhanced_bookmark_model.cc b/components/enhanced_bookmarks/enhanced_bookmark_model.cc
index f1ed980ed291093af134c9acf4b390d05f4178bd..42bb5cec1df2a6f56d0b689d7d2bac1c7cb4b89d 100644
--- a/components/enhanced_bookmarks/enhanced_bookmark_model.cc
+++ b/components/enhanced_bookmarks/enhanced_bookmark_model.cc
@@ -25,7 +25,6 @@ using bookmarks::BookmarkNode;
namespace {
const char* kBookmarkBarId = "f_bookmarks_bar";
-const char* kFlagsKey = "stars.flags";
const char* kIdKey = "stars.id";
const char* kImageDataKey = "stars.imageData";
const char* kNoteKey = "stars.note";
@@ -35,11 +34,6 @@ const char* kVersionKey = "stars.version";
const char* kBookmarkPrefix = "ebc_";
-enum Flags {
- // When set the server will attempt to fill in image and snippet information.
- NEEDS_OFFLINE_PROCESSING = 0x1,
-};
-
// Helper method for working with bookmark metainfo.
std::string DataForMetaInfoField(const BookmarkNode* node,
const std::string& field) {
@@ -312,14 +306,6 @@ void EnhancedBookmarkModel::BookmarkNodeAdded(BookmarkModel* model,
if (node->GetMetaInfo(kIdKey, &remote_id)) {
AddToIdMap(node);
ScheduleResetDuplicateRemoteIds();
- } else if (node->is_url()) {
- set_needs_offline_processing_tasks_[node] =
- make_linked_ptr(new base::CancelableClosure(
- base::Bind(&EnhancedBookmarkModel::SetNeedsOfflineProcessing,
- weak_ptr_factory_.GetWeakPtr(),
- base::Unretained(node))));
- base::MessageLoopProxy::current()->PostTask(
- FROM_HERE, set_needs_offline_processing_tasks_[node]->callback());
}
FOR_EACH_OBSERVER(
EnhancedBookmarkModelObserver, observers_, EnhancedBookmarkAdded(node));
@@ -408,7 +394,6 @@ void EnhancedBookmarkModel::RemoveNodeFromMaps(const BookmarkNode* node) {
std::string remote_id = GetRemoteId(node);
id_map_.erase(remote_id);
nodes_to_reset_.erase(node);
- set_needs_offline_processing_tasks_.erase(node);
}
void EnhancedBookmarkModel::ScheduleResetDuplicateRemoteIds() {
@@ -432,19 +417,6 @@ void EnhancedBookmarkModel::ResetDuplicateRemoteIds() {
nodes_to_reset_.clear();
}
-void EnhancedBookmarkModel::SetNeedsOfflineProcessing(
- const BookmarkNode* node) {
- set_needs_offline_processing_tasks_.erase(node);
- int flags = 0;
- std::string flags_str;
- if (node->GetMetaInfo(kFlagsKey, &flags_str)) {
- if (!base::StringToInt(flags_str, &flags))
- flags = 0;
- }
- flags |= NEEDS_OFFLINE_PROCESSING;
- SetMetaInfo(node, kFlagsKey, base::IntToString(flags));
-}
-
void EnhancedBookmarkModel::SetMetaInfo(const BookmarkNode* node,
const std::string& field,
const std::string& value) {

Powered by Google App Engine
This is Rietveld 408576698