chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html - Issue 888343003: Ctrl-G now selects page number in Material Design PDF Viewer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

Issue 888343003: Ctrl-G now selects page number in Material Design PDF Viewer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing quotation mark Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css ('k') | chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

diff --git a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

index 966996f10e9b926bde6c8fac0e34166a1dd09e01..265cc1801c9c1102281a149332454ac6ad074b77 100644

--- a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

+++ b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

@@ -1,12 +1,13 @@

-<link rel="import" href="chrome://resources/polymer/paper-input/paper-input.html">

+<link rel="import" href="chrome://resources/polymer/paper-input/paper-input-decorator.html">

<polymer-element name="viewer-page-selector">

- <paper-input value="{{pageNo}}"

- committedValue="{{chosenPageNo}}"

- id="pageselector"></paper-input>

+ <paper-input-decorator id="pageselector" value="{{pageNo}}">

Sam McNally 2015/02/02 06:04:30 Does this need a value?

Alexandre Carlton 2015/02/02 06:29:01 No; the original paper-input (a convenience elemen

+ <input id="input" is="core-input"

+ value="{{pageNo}}" committedvalue="{{chosenPageNo}}">

+ </paper-input-decorator>

<span id="pagelength">/ {{docLength}}</span>

</template>