chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html - Issue 888343003: Ctrl-G now selects page number in Material Design PDF Viewer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

Issue 888343003: Ctrl-G now selects page number in Material Design PDF Viewer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing quotation mark Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css ('k') | chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/paper-input/paper-input.html ">	2 <link rel="import" href="chrome://resources/polymer/paper-input/paper-input-deco rator.html">

3	3

4 <polymer-element name="viewer-page-selector">	4 <polymer-element name="viewer-page-selector">

5 <template>	5 <template>

6 <link rel="stylesheet" href="viewer-page-selector.css">	6 <link rel="stylesheet" href="viewer-page-selector.css">

7 <paper-input value="{{pageNo}}"	7 <paper-input-decorator id="pageselector" value="{{pageNo}}">
	Sam McNally 2015/02/02 06:04:30 Does this need a value? Does this need a value? Alexandre Carlton 2015/02/02 06:29:01 No; the original paper-input (a convenience elemen Show quoted text On 2015/02/02 06:04:30, Sam McNally wrote: > Does this need a value? No; the original paper-input (a convenience element on which this is based) sets this, however removing it appears to have no impact on functionality (and no reference is made to it in paper-input-decorator.js, only this.input.value).
8 committedValue="{{chosenPageNo}}"	8 <input id="input" is="core-input"

9 id="pageselector"></paper-input>	9 value="{{pageNo}}" committedvalue="{{chosenPageNo}}">

	10 </paper-input-decorator>

10 <span id="pagelength">/ {{docLength}}</span>	11 <span id="pagelength">/ {{docLength}}</span>

11 </template>	12 </template>

12 <script src="viewer-page-selector.js"></script>	13 <script src="viewer-page-selector.js"></script>

13 </polymer-element>	14 </polymer-element>

OLD	NEW