Ctrl-G now selects page number in Material Design PDF Viewer

Ctrl-G now selects page number in Material Design PDF Viewer

Previously, typing Ctrl-G would pop up the "find-text" box, appearing to be an alias for Ctrl-F.
Doing so will now highlight the page number in the viewer-page-selector, allowing for a quick and easy method to go to another page.
Changed viewer-page-selector to use a combination of paper-input-decorator and input instead of a sole paper-input. This affords us greater flexibility and should ease maintenance.

BUG=55920
Committed: https://crrev.com/2e71a490ed06350c99a5ccad1b44d385d70abd86
Cr-Commit-Position: refs/heads/master@{#314291}

[Alexandre Carlton, 2015-02-01 22:46:09]

alexandrec@chromium.org changed reviewers:
+ benwells@chromium.org, raymes@chromium.org, sammc@chromium.org

[raymes, 2015-02-01 23:47:02]

https://codereview.chromium.org/888343003/diff/1/chrome/browser/resources/pdf...
File
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
(right):

https://codereview.chromium.org/888343003/diff/1/chrome/browser/resources/pdf...
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html:2:
<link rel="import" href="chrome://resources/polymer/core-input/core-input.html">
do we need this?

https://codereview.chromium.org/888343003/diff/1/chrome/browser/resources/pdf...
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html:9:
<input id="input" is="core-input"
Whoa! What does "is=" do? It seems very magical.

https://codereview.chromium.org/888343003/diff/1/chrome/browser/resources/pdf...
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html:10:
value="{{pageNo}}" committedvalue="{{chosenPageNo}}">
4-space indent

https://codereview.chromium.org/888343003/diff/1/chrome/browser/resources/pdf...
File chrome/browser/resources/pdf/pdf.js (right):

https://codereview.chromium.org/888343003/diff/1/chrome/browser/resources/pdf...
chrome/browser/resources/pdf/pdf.js:258: // Since this is bound to Find Text.
// To prevent the default "find text" behavior in Chrome.

[Alexandre Carlton, 2015-02-02 00:05:32]

https://codereview.chromium.org/888343003/diff/1/chrome/browser/resources/pdf...
File
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
(right):

https://codereview.chromium.org/888343003/diff/1/chrome/browser/resources/pdf...
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html:2:
<link rel="import" href="chrome://resources/polymer/core-input/core-input.html">
On 2015/02/01 23:47:02, raymes wrote:
> do we need this?

No, I've now removed it.

https://codereview.chromium.org/888343003/diff/1/chrome/browser/resources/pdf...
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html:9:
<input id="input" is="core-input"
On 2015/02/01 23:47:02, raymes wrote:
> Whoa! What does "is=" do? It seems very magical.

It's a type extension; the Polymer Docs talk about it briefly
(https://www.polymer-project.org/platform/custom-elements.html#instantiating-a...).
Note that core-input extends input.

More detailed information can be found here:
http://w3c.github.io/webcomponents/spec/custom/

https://codereview.chromium.org/888343003/diff/1/chrome/browser/resources/pdf...
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html:10:
value="{{pageNo}}" committedvalue="{{chosenPageNo}}">
On 2015/02/01 23:47:02, raymes wrote:
> 4-space indent

Done.

https://codereview.chromium.org/888343003/diff/1/chrome/browser/resources/pdf...
File chrome/browser/resources/pdf/pdf.js (right):

https://codereview.chromium.org/888343003/diff/1/chrome/browser/resources/pdf...
chrome/browser/resources/pdf/pdf.js:258: // Since this is bound to Find Text.
On 2015/02/01 23:47:02, raymes wrote:
> // To prevent the default "find text" behavior in Chrome.

Done.

[raymes, 2015-02-02 00:28:10]

lgtm

[Sam McNally, 2015-02-02 06:04:31]

Where does ctrl-g select page number?

https://codereview.chromium.org/888343003/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
(right):

https://codereview.chromium.org/888343003/diff/40001/chrome/browser/resources...
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html:7:
<paper-input-decorator id="pageselector" value="{{pageNo}}">
Does this need a value?

[Alexandre Carlton, 2015-02-02 06:29:01]

https://codereview.chromium.org/888343003/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
(right):

https://codereview.chromium.org/888343003/diff/40001/chrome/browser/resources...
chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html:7:
<paper-input-decorator id="pageselector" value="{{pageNo}}">
On 2015/02/02 06:04:30, Sam McNally wrote:
> Does this need a value?

No; the original paper-input (a convenience element on which this is based) sets
this, however removing it appears to have no impact on functionality (and no
reference is made to it in paper-input-decorator.js, only this.input.value).

[benwells, 2015-02-02 10:29:37]

lgtm

[Sam McNally, 2015-02-03 07:23:10]

lgtm

[Alexandre Carlton, 2015-02-03 07:41:55]

The CQ bit was checked by alexandrec@chromium.org

[commit-bot: I haz the power, 2015-02-03 07:42:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/888343003/80001

[commit-bot: I haz the power, 2015-02-03 08:27:15]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-03 08:28:27]

Patchset 5 (id:??) landed as
https://crrev.com/2e71a490ed06350c99a5ccad1b44d385d70abd86
Cr-Commit-Position: refs/heads/master@{#314291}