Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html

Issue 888343003: Ctrl-G now selects page number in Material Design PDF Viewer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
diff --git a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
index 966996f10e9b926bde6c8fac0e34166a1dd09e01..d066719d6091a7a94ef284e86b7750d431c2190d 100644
--- a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
+++ b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html
@@ -1,12 +1,14 @@
<link rel="import" href="chrome://resources/polymer/polymer/polymer.html">
-<link rel="import" href="chrome://resources/polymer/paper-input/paper-input.html">
+<link rel="import" href="chrome://resources/polymer/core-input/core-input.html">
raymes 2015/02/01 23:47:02 do we need this?
Alexandre Carlton 2015/02/02 00:05:32 No, I've now removed it.
+<link rel="import" href="chrome://resources/polymer/paper-input/paper-input-decorator.html">
<polymer-element name="viewer-page-selector">
<template>
<link rel="stylesheet" href="viewer-page-selector.css">
- <paper-input value="{{pageNo}}"
- committedValue="{{chosenPageNo}}"
- id="pageselector"></paper-input>
+ <paper-input-decorator id="pageselector" value="{{pageNo}}">
+ <input id="input" is="core-input"
raymes 2015/02/01 23:47:02 Whoa! What does "is=" do? It seems very magical.
Alexandre Carlton 2015/02/02 00:05:32 It's a type extension; the Polymer Docs talk about
+ value="{{pageNo}}" committedvalue="{{chosenPageNo}}">
raymes 2015/02/01 23:47:02 4-space indent
Alexandre Carlton 2015/02/02 00:05:32 Done.
+ </paper-input-decorator>
<span id="pagelength">/ {{docLength}}</span>
</template>
<script src="viewer-page-selector.js"></script>

Powered by Google App Engine
This is Rietveld 408576698