chrome/browser/resources/pdf/pdf.js - Issue 888343003: Ctrl-G now selects page number in Material Design PDF Viewer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/pdf.js

Issue 888343003: Ctrl-G now selects page number in Material Design PDF Viewer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html ('K') | « chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/pdf.js

diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js

index fb4d3ee53a3d7d19b7c918089fcc09b3de7097a1..6ca0836947c55ec15eb888cc65f461bce88e8b60 100644

--- a/chrome/browser/resources/pdf/pdf.js

+++ b/chrome/browser/resources/pdf/pdf.js

@@ -252,6 +252,13 @@ PDFViewer.prototype = {

});

}

return;

+ case 71: // g key.

+ if (this.isMaterial_ && (e.ctrlKey || e.metaKey)) {

+ this.pageIndicator_.select();

+ // Since this is bound to Find Text.

raymes 2015/02/01 23:47:02 // To prevent the default "find text" behavior in

Alexandre Carlton 2015/02/02 00:05:32 Done.

+ e.preventDefault();

+ }

+ return;

case 80: // p key.

if (e.ctrlKey || e.metaKey) {

this.print_();