Issue 88813005: Support Mac frameworks in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88813005: Support Mac frameworks in GN. (Closed)

Created:
7 years ago by brettw

Modified:
7 years ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Support Mac frameworks in GN. This special cases libs ending in ".framework" on Mac and removes the mac-specific hacks in the binary target writer. BUG=304344 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237622

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -16 lines)			Patch
M	tools/gn/function_toolchain.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/gn/ninja_binary_target_writer.cc	View		1 chunk	+12 lines, -7 lines	0 comments	Download
M	tools/gn/secondary/base/BUILD.gn	View	1	4 chunks	+22 lines, -9 lines	0 comments	Download
M	tools/gn/variables.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

Committed patchset #2 manually as r237622 (presubmit successful).