Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/function_toolchain.cc

Issue 88813005: Support Mac frameworks in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_toolchain.cc
diff --git a/tools/gn/function_toolchain.cc b/tools/gn/function_toolchain.cc
index cbd8826fa850180a94c23a31bea212779845131a..ccba2d13405a7bd7b855e48fbd45aa8ddfc33d6c 100644
--- a/tools/gn/function_toolchain.cc
+++ b/tools/gn/function_toolchain.cc
@@ -151,6 +151,10 @@ const char kTool_Help[] =
" search directories, respectively, because linkers differ on how to\n"
" specify them.\n"
"\n"
+ " Note: On Mac libraries with names ending in \".framework\" will be\n"
+ " added to the link like with a \"-framework\" switch and the lib prefix\n"
+ " will be ignored.\n"
+ "\n"
"Example:\n"
" toolchain(\"my_toolchain\") {\n"
" # Put these at the top to apply to all tools below.\n"
« no previous file with comments | « no previous file | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698