Support Mac frameworks in GN.

tools/gn/ninja_binary_target_writer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/ninja_binary_target_writer.h"
 
 #include <set>
 
 #include "base/strings/string_util.h"
 #include "tools/gn/config_values_extractors.h"
@@ skipping 261 matching lines @@
   // HACK ERASEME BRETTW FIXME
   if (settings_->IsWin()) {
     out_ << " /MANIFEST /ManifestFile:";
     path_output_.WriteFile(out_, windows_manifest);
   }
   out_ << std::endl;
 }
 
 void NinjaBinaryTargetWriter::WriteLibs(const Toolchain::Tool& tool) {
   out_ << "libs =";
-  if (settings_->IsMac()) {
-    // TODO(brettw) write frameworks correctly for Mac.
-    out_ << " -framework AppKit -framework ApplicationServices -framework Carbon -framework CoreFoundation -framework Foundation -framework IOKit -framework Security";
-  }
 
   // Libraries that have been recursively pushed through the dependency tree.
   EscapeOptions lib_escape_opts;
   lib_escape_opts.mode = ESCAPE_NINJA_SHELL;
   const OrderedSet<std::string> all_libs = target_->all_libs();
+  const std::string framework_ending(".framework");
   for (size_t i = 0; i < all_libs.size(); i++) {
-    out_ << " " << tool.lib_prefix;
-    EscapeStringToStream(out_, all_libs[i], lib_escape_opts);
-    out_ << "";
+    if (settings_->IsMac() && EndsWith(all_libs[i], framework_ending, false)) {
+      // Special-case libraries ending in ".framework" on Mac. Add the
+      // -framework switch and don't add the extension to the output.
+      out_ << " -framework ";
+      EscapeStringToStream(out_,
+          all_libs[i].substr(0, all_libs[i].size() - framework_ending.size()),
+          lib_escape_opts);
+    } else {
+      out_ << " " << tool.lib_prefix;
+      EscapeStringToStream(out_, all_libs[i], lib_escape_opts);
+    }
   }
   out_ << std::endl;
 }
 
 void NinjaBinaryTargetWriter::WriteLinkCommand(
     const OutputFile& external_output_file,
     const OutputFile& internal_output_file,
     const std::vector<OutputFile>& object_files) {
   out_ << "build ";
   path_output_.WriteFile(out_, internal_output_file);
@@ skipping 148 matching lines @@
     }
 
     // Data files.
     const std::vector<SourceFile>& data = target_->data();
     for (size_t i = 0; i < data.size(); i++) {
       out_ << " ";
       path_output_.WriteFile(out_, data[i]);
     }
   }
 }