Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 887673002: DevTools: CPU profiler sunburst view (Closed)

Created:
5 years, 10 months ago by yurys
Modified:
5 years, 9 months ago
Reviewers:
alph
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: CPU profiler sunburst view This patch adds sunburst view to CPU profiler. It is based on https://github.com/Etsukata/d3js_trace BUG=452624

Patch Set 1 #

Patch Set 2 : Added d3js_trace #

Total comments: 1

Patch Set 3 : Enlarge the chart and use non-minified d3.js #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+885 lines, -0 lines) Patch
M Source/devtools/front_end/profiler/CPUProfileView.js View 1 2 5 chunks +56 lines, -0 lines 0 comments Download
A Source/devtools/front_end/profiler/d3js_trace/LICENSE View 1 1 chunk +202 lines, -0 lines 0 comments Download
A Source/devtools/front_end/profiler/d3js_trace/README.md View 1 1 chunk +75 lines, -0 lines 0 comments Download
A Source/devtools/front_end/profiler/d3js_trace/d3trace.py View 1 1 chunk +133 lines, -0 lines 0 comments Download
A Source/devtools/front_end/profiler/d3js_trace/img/screen_seq.png View 1 Binary file 0 comments Download
A Source/devtools/front_end/profiler/d3js_trace/index.html View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A Source/devtools/front_end/profiler/d3js_trace/sequences.css View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
A Source/devtools/front_end/profiler/d3js_trace/sequences.js View 1 2 3 1 chunk +331 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
yurys
PS#3 should give results like http://i.imgur.com/PEnE0wW.png
5 years, 10 months ago (2015-01-29 14:23:48 UTC) #1
alph
https://codereview.chromium.org/887673002/diff/20001/Source/devtools/front_end/profiler/CPUProfileView.js File Source/devtools/front_end/profiler/CPUProfileView.js (right): https://codereview.chromium.org/887673002/diff/20001/Source/devtools/front_end/profiler/CPUProfileView.js#newcode859 Source/devtools/front_end/profiler/CPUProfileView.js:859: for (var i = 0; i < node.children.length; i++) ...
5 years, 10 months ago (2015-01-29 14:25:47 UTC) #3
yurys
This is patch is not intended to be landed.
5 years, 10 months ago (2015-01-29 14:26:47 UTC) #4
pfeldman
5 years, 10 months ago (2015-01-29 20:18:36 UTC) #5
We need to bind it to the overview selection.

Powered by Google App Engine
This is Rietveld 408576698