Source/modules/serviceworkers/ServiceWorkerThread.h - Issue 887463003: Turn WorkerLoaderProxy into a threadsafe, ref-counted object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerThread.h

Issue 887463003: Turn WorkerLoaderProxy into a threadsafe, ref-counted object. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Explicitly detach instead of using a weak abstraction Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/workers/WorkerLoaderProxy.h ('K') | « Source/core/workers/WorkerThread.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerThread.cpp » ('j') | Source/web/WebEmbeddedWorkerImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerThread.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerThread.h b/Source/modules/serviceworkers/ServiceWorkerThread.h

index a1430caad59c5dbe8f2f940008acad226d2bb3b9..d72c5cb7ecd57eac2c1c174c207c2b7b3f2fd033 100644

--- a/Source/modules/serviceworkers/ServiceWorkerThread.h

+++ b/Source/modules/serviceworkers/ServiceWorkerThread.h

@@ -39,14 +39,14 @@ class WorkerThreadStartupData;

class ServiceWorkerThread final : public WorkerThread {

public:

- static PassRefPtr<ServiceWorkerThread> create(WorkerLoaderProxy&, WorkerReportingProxy&, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData>);

+ static PassRefPtr<ServiceWorkerThread> create(PassRefPtr<WorkerLoaderProxy>, WorkerReportingProxy&, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData>);

virtual ~ServiceWorkerThread();

protected:

virtual PassRefPtrWillBeRawPtr<WorkerGlobalScope> createWorkerGlobalScope(PassOwnPtrWillBeRawPtr<WorkerThreadStartupData>) override;

private:

- ServiceWorkerThread(WorkerLoaderProxy&, WorkerReportingProxy&, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData>);

+ ServiceWorkerThread(PassRefPtr<WorkerLoaderProxy>, WorkerReportingProxy&, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData>);

};

} // namespace blink