Source/modules/serviceworkers/ServiceWorkerThread.cpp - Issue 887463003: Turn WorkerLoaderProxy into a threadsafe, ref-counted object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerThread.cpp

Issue 887463003: Turn WorkerLoaderProxy into a threadsafe, ref-counted object. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Explicitly detach instead of using a weak abstraction Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/workers/WorkerLoaderProxy.h ('K') | « Source/modules/serviceworkers/ServiceWorkerThread.h ('k') | Source/modules/websockets/WorkerWebSocketChannel.h » ('j') | Source/web/WebEmbeddedWorkerImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerThread.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorkerThread.cpp b/Source/modules/serviceworkers/ServiceWorkerThread.cpp

index b732b91339184ca77bbfffc98dd6f96ddf2e0cd9..022975d948efd3fd049915ca8ca6373ae9d592ab 100644

--- a/Source/modules/serviceworkers/ServiceWorkerThread.cpp

+++ b/Source/modules/serviceworkers/ServiceWorkerThread.cpp

@@ -37,12 +37,12 @@

namespace blink {

-PassRefPtr<ServiceWorkerThread> ServiceWorkerThread::create(WorkerLoaderProxy& workerLoaderProxy, WorkerReportingProxy& workerReportingProxy, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData> startupData)

+PassRefPtr<ServiceWorkerThread> ServiceWorkerThread::create(PassRefPtr<WorkerLoaderProxy> workerLoaderProxy, WorkerReportingProxy& workerReportingProxy, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData> startupData)

{

return adoptRef(new ServiceWorkerThread(workerLoaderProxy, workerReportingProxy, startupData));

}

-ServiceWorkerThread::ServiceWorkerThread(WorkerLoaderProxy& workerLoaderProxy, WorkerReportingProxy& workerReportingProxy, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData> startupData)

+ServiceWorkerThread::ServiceWorkerThread(PassRefPtr<WorkerLoaderProxy> workerLoaderProxy, WorkerReportingProxy& workerReportingProxy, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData> startupData)

: WorkerThread(workerLoaderProxy, workerReportingProxy, startupData)

{

}