Source/core/workers/WorkerThread.cpp - Issue 887463003: Turn WorkerLoaderProxy into a threadsafe, ref-counted object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/WorkerThread.cpp

Issue 887463003: Turn WorkerLoaderProxy into a threadsafe, ref-counted object. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Explicitly detach instead of using a weak abstraction Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/workers/WorkerLoaderProxy.h ('K') | « Source/core/workers/WorkerThread.h ('k') | Source/modules/serviceworkers/ServiceWorkerThread.h » ('j') | Source/web/WebEmbeddedWorkerImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/workers/WorkerThread.cpp

diff --git a/Source/core/workers/WorkerThread.cpp b/Source/core/workers/WorkerThread.cpp

index 64b2f7f36f02b2a17965fe40227b178c08254a64..228856e5957f732bfe6791e5eb0ea4aefc040447 100644

--- a/Source/core/workers/WorkerThread.cpp

+++ b/Source/core/workers/WorkerThread.cpp

@@ -251,7 +251,7 @@ private:

WorkerThread* m_thread;

};

-WorkerThread::WorkerThread(WorkerLoaderProxy& workerLoaderProxy, WorkerReportingProxy& workerReportingProxy, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData> startupData)

+WorkerThread::WorkerThread(PassRefPtr<WorkerLoaderProxy> workerLoaderProxy, WorkerReportingProxy& workerReportingProxy, PassOwnPtrWillBeRawPtr<WorkerThreadStartupData> startupData)

: m_terminated(false)

, m_workerLoaderProxy(workerLoaderProxy)

, m_workerReportingProxy(workerReportingProxy)