Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: net/cert/x509_certificate.h

Issue 886933008: Fix a memory leak in net::CertVerifyProcMac::VerifyInternal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/cert_verify_proc_mac.cc ('k') | net/cert/x509_certificate_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/x509_certificate.h
diff --git a/net/cert/x509_certificate.h b/net/cert/x509_certificate.h
index c1a4f6defed148d1551070651a03af7e3a3ce800..6c0f0e97e332c1988ac41741b526288228b8ad61 100644
--- a/net/cert/x509_certificate.h
+++ b/net/cert/x509_certificate.h
@@ -251,12 +251,12 @@ class NET_EXPORT X509Certificate
// Does this certificate's usage allow SSL client authentication?
bool SupportsSSLClientAuth() const;
- // Returns a new CFArrayRef containing this certificate and its intermediate
- // certificates in the form expected by Security.framework and Keychain
- // Services, or NULL on failure.
+ // Returns a new CFMutableArrayRef containing this certificate and its
+ // intermediate certificates in the form expected by Security.framework
+ // and Keychain Services, or NULL on failure.
// The first item in the array will be this certificate, followed by its
// intermediates, if any.
- CFArrayRef CreateOSCertChainForCert() const;
+ CFMutableArrayRef CreateOSCertChainForCert() const;
#endif
// Do any of the given issuer names appear in this cert's chain of trust?
« no previous file with comments | « net/cert/cert_verify_proc_mac.cc ('k') | net/cert/x509_certificate_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698