Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: net/cert/x509_certificate.h

Issue 886933008: Fix a memory leak in net::CertVerifyProcMac::VerifyInternal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/cert/cert_verify_proc_mac.cc ('k') | net/cert/x509_certificate_mac.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_CERT_X509_CERTIFICATE_H_ 5 #ifndef NET_CERT_X509_CERTIFICATE_H_
6 #define NET_CERT_X509_CERTIFICATE_H_ 6 #define NET_CERT_X509_CERTIFICATE_H_
7 7
8 #include <string.h> 8 #include <string.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 // Ownership follows the "get" rule: it is the caller's responsibility to 244 // Ownership follows the "get" rule: it is the caller's responsibility to
245 // retain the elements of the result. 245 // retain the elements of the result.
246 const OSCertHandles& GetIntermediateCertificates() const { 246 const OSCertHandles& GetIntermediateCertificates() const {
247 return intermediate_ca_certs_; 247 return intermediate_ca_certs_;
248 } 248 }
249 249
250 #if defined(OS_MACOSX) 250 #if defined(OS_MACOSX)
251 // Does this certificate's usage allow SSL client authentication? 251 // Does this certificate's usage allow SSL client authentication?
252 bool SupportsSSLClientAuth() const; 252 bool SupportsSSLClientAuth() const;
253 253
254 // Returns a new CFArrayRef containing this certificate and its intermediate 254 // Returns a new CFMutableArrayRef containing this certificate and its
255 // certificates in the form expected by Security.framework and Keychain 255 // intermediate certificates in the form expected by Security.framework
256 // Services, or NULL on failure. 256 // and Keychain Services, or NULL on failure.
257 // The first item in the array will be this certificate, followed by its 257 // The first item in the array will be this certificate, followed by its
258 // intermediates, if any. 258 // intermediates, if any.
259 CFArrayRef CreateOSCertChainForCert() const; 259 CFMutableArrayRef CreateOSCertChainForCert() const;
260 #endif 260 #endif
261 261
262 // Do any of the given issuer names appear in this cert's chain of trust? 262 // Do any of the given issuer names appear in this cert's chain of trust?
263 // |valid_issuers| is a list of DER-encoded X.509 DistinguishedNames. 263 // |valid_issuers| is a list of DER-encoded X.509 DistinguishedNames.
264 bool IsIssuedByEncoded(const std::vector<std::string>& valid_issuers); 264 bool IsIssuedByEncoded(const std::vector<std::string>& valid_issuers);
265 265
266 #if defined(OS_WIN) 266 #if defined(OS_WIN)
267 // Returns a new PCCERT_CONTEXT containing this certificate and its 267 // Returns a new PCCERT_CONTEXT containing this certificate and its
268 // intermediate certificates, or NULL on failure. The returned 268 // intermediate certificates, or NULL on failure. The returned
269 // PCCERT_CONTEXT *MUST NOT* be stored in an X509Certificate, as this will 269 // PCCERT_CONTEXT *MUST NOT* be stored in an X509Certificate, as this will
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
515 // based on the type of the certificate. 515 // based on the type of the certificate.
516 std::string default_nickname_; 516 std::string default_nickname_;
517 #endif 517 #endif
518 518
519 DISALLOW_COPY_AND_ASSIGN(X509Certificate); 519 DISALLOW_COPY_AND_ASSIGN(X509Certificate);
520 }; 520 };
521 521
522 } // namespace net 522 } // namespace net
523 523
524 #endif // NET_CERT_X509_CERTIFICATE_H_ 524 #endif // NET_CERT_X509_CERTIFICATE_H_
OLDNEW
« no previous file with comments | « net/cert/cert_verify_proc_mac.cc ('k') | net/cert/x509_certificate_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698