net/cert/x509_certificate_mac.cc - Issue 886933008: Fix a memory leak in net::CertVerifyProcMac::VerifyInternal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_certificate_mac.cc

Issue 886933008: Fix a memory leak in net::CertVerifyProcMac::VerifyInternal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/x509_certificate_mac.cc

diff --git a/net/cert/x509_certificate_mac.cc b/net/cert/x509_certificate_mac.cc

index f8bfe12c71489915be70dd5babe7313198791862..10cfb56f4c0279f4041beae594262f03c9ccc64a 100644

--- a/net/cert/x509_certificate_mac.cc

+++ b/net/cert/x509_certificate_mac.cc

@@ -449,7 +449,7 @@ bool X509Certificate::SupportsSSLClientAuth() const {

return true;

}

-CFArrayRef X509Certificate::CreateOSCertChainForCert() const {

+CFMutableArrayRef X509Certificate::CreateOSCertChainForCert() const {

CFMutableArrayRef cert_list =

CFArrayCreateMutable(kCFAllocatorDefault, 0,

&kCFTypeArrayCallBacks);

« no previous file with comments | « net/cert/x509_certificate.h ('k') | tools/valgrind/memcheck/suppressions_mac.txt » ('j') | no next file with comments »