Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 886893002: Add GesturePinchBegin/End events on Mac (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GesturePinchBegin/End events on Mac Because a single gesture (in NSEvent-speak) can contain multiple types of sub-gestures (e.g, pinch and rotate), we do not get a begin/end of the magnify-only part of the gesture. Work around this by saving the NSEvent-gesture's beginning event, sending it (with the right type) when the magnification begins, and sending an end event when the gesture ends (only if a magnification event was sent). BUG=451559 Committed: https://crrev.com/be0b14cb9955f2b4674e5f5f11755eb9f6276658 Cr-Commit-Position: refs/heads/master@{#314594}

Patch Set 1 #

Patch Set 2 : Add mock gesture events #

Patch Set 3 : Update OWNERS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -17 lines) Patch
A chrome/browser/renderer_host/OWNERS View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm View 1 2 chunks +24 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 chunks +38 lines, -9 lines 0 comments Download

Messages

Total messages: 28 (9 generated)
ccameron
ptal (small change)
5 years, 10 months ago (2015-01-29 23:04:45 UTC) #2
erikchen
lgtm
5 years, 10 months ago (2015-01-30 18:36:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886893002/1
5 years, 10 months ago (2015-02-02 18:18:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/29576)
5 years, 10 months ago (2015-02-02 19:35:31 UTC) #7
ccameron
Sky, could you stamp this? erikchen, can you take a second look at the browser ...
5 years, 10 months ago (2015-02-02 22:37:59 UTC) #9
sky
Can you pick a more local owner please? I'm not the best for mac changes. ...
5 years, 10 months ago (2015-02-03 00:39:26 UTC) #10
ccameron
Last time I tried going with one of the *.mm OWNERS, that wasn't sufficient (see ...
5 years, 10 months ago (2015-02-03 00:46:35 UTC) #11
ccameron
Adding avi for real this time.
5 years, 10 months ago (2015-02-03 23:37:29 UTC) #13
erikchen
lgtm
5 years, 10 months ago (2015-02-03 23:39:01 UTC) #14
Avi (use Gerrit)
lgtm
5 years, 10 months ago (2015-02-04 00:22:23 UTC) #15
ccameron
Thanks!
5 years, 10 months ago (2015-02-04 00:23:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886893002/20001
5 years, 10 months ago (2015-02-04 00:24:25 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/40219)
5 years, 10 months ago (2015-02-04 00:30:03 UTC) #20
ccameron
sky, please review OWNERS change. Added an OWNERS for this directory -- added the usual ...
5 years, 10 months ago (2015-02-04 01:30:26 UTC) #22
sky
LGTM
5 years, 10 months ago (2015-02-04 18:05:45 UTC) #23
ccameron
Thanks!
5 years, 10 months ago (2015-02-04 18:06:30 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886893002/40001
5 years, 10 months ago (2015-02-04 18:07:25 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-04 18:45:18 UTC) #27
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 18:46:27 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/be0b14cb9955f2b4674e5f5f11755eb9f6276658
Cr-Commit-Position: refs/heads/master@{#314594}

Powered by Google App Engine
This is Rietveld 408576698