Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 811383003: Fix ChromeRenderWidgetHostViewMacHistorySwiperTest.TestMostlyHorizontal (Closed)

Created:
5 years, 11 months ago by ccameron
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromeRenderWidgetHostViewMacHistorySwiperTest.TestMostlyHorizontal Change the PhaseBegan to not cause a vertical scroll. Deltas for PhaseBegan events are incorrectly ignored by ScrollElasticityController. The PhaseBegan deltas are not ignored by impl-side scrolling, which causes the test to fail. If ScrollElasticityController is corrected to not ignore PhaseBegan deltas, the test fails as well. By changing the delta for PhaseBegan, the test passes both with impl-side scrolling and with the corrected ScrollElasticityController. BUG=133097 Committed: https://crrev.com/5fa865cf531895e944c6499068ec00b62576f180 Cr-Commit-Position: refs/heads/master@{#310148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
ccameron
Small fix (last Chromium test failing with impl event handling).
5 years, 11 months ago (2015-01-02 22:15:52 UTC) #2
erikchen
lgtm
5 years, 11 months ago (2015-01-05 18:54:11 UTC) #3
ccameron
Adding avi for OWNER stamp.
5 years, 11 months ago (2015-01-05 18:56:29 UTC) #5
Avi (use Gerrit)
lgtm stampity stamp
5 years, 11 months ago (2015-01-05 19:50:31 UTC) #6
ccameron
Thanks!
5 years, 11 months ago (2015-01-05 20:14:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811383003/1
5 years, 11 months ago (2015-01-05 20:15:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/33184)
5 years, 11 months ago (2015-01-05 20:22:22 UTC) #11
ccameron
sky, can you stamp this? On 2015/01/05 20:22:22, I haz the power (commit-bot) wrote: > ...
5 years, 11 months ago (2015-01-06 19:14:17 UTC) #13
sky
LGTM
5 years, 11 months ago (2015-01-06 21:07:16 UTC) #14
ccameron
Thanks!
5 years, 11 months ago (2015-01-06 21:11:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811383003/1
5 years, 11 months ago (2015-01-06 21:15:58 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 21:20:40 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 21:22:13 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fa865cf531895e944c6499068ec00b62576f180
Cr-Commit-Position: refs/heads/master@{#310148}

Powered by Google App Engine
This is Rietveld 408576698