Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 886893002: Add GesturePinchBegin/End events on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update OWNERS file Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index 01e60c5b6ac3a7e3e907d753c8df49ce12682ff7..b0150f8744811f10c51a513c916bcd38f0af3fc2 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -2239,19 +2239,37 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
- (void)beginGestureWithEvent:(NSEvent*)event {
[responderDelegate_ beginGestureWithEvent:event];
+ gestureBeginEvent_.reset(
+ new WebGestureEvent(WebInputEventFactory::gestureEvent(event, self)));
}
+
- (void)endGestureWithEvent:(NSEvent*)event {
[responderDelegate_ endGestureWithEvent:event];
+ gestureBeginEvent_.reset();
+
+ if (!renderWidgetHostView_->render_widget_host_)
+ return;
+
+ if (gestureBeginPinchSent_) {
+ WebGestureEvent endEvent(WebInputEventFactory::gestureEvent(event, self));
+ endEvent.type = WebInputEvent::GesturePinchEnd;
+ renderWidgetHostView_->render_widget_host_->ForwardGestureEvent(endEvent);
+ gestureBeginPinchSent_ = NO;
+ }
}
+
- (void)touchesMovedWithEvent:(NSEvent*)event {
[responderDelegate_ touchesMovedWithEvent:event];
}
+
- (void)touchesBeganWithEvent:(NSEvent*)event {
[responderDelegate_ touchesBeganWithEvent:event];
}
+
- (void)touchesCancelledWithEvent:(NSEvent*)event {
[responderDelegate_ touchesCancelledWithEvent:event];
}
+
- (void)touchesEndedWithEvent:(NSEvent*)event {
[responderDelegate_ touchesEndedWithEvent:event];
}
@@ -2330,16 +2348,27 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
// Called repeatedly during a pinch gesture, with incremental change values.
- (void)magnifyWithEvent:(NSEvent*)event {
- if (renderWidgetHostView_->render_widget_host_) {
- // Send a GesturePinchUpdate event.
- // Note that we don't attempt to bracket these by GesturePinchBegin/End (or
- // GestureSrollBegin/End) as is done for touchscreen. Keeping track of when
- // a pinch is active would take a little more work here, and we don't need
- // it for anything yet.
- const WebGestureEvent& webEvent =
- WebInputEventFactory::gestureEvent(event, self);
- renderWidgetHostView_->render_widget_host_->ForwardGestureEvent(webEvent);
+ if (!renderWidgetHostView_->render_widget_host_)
+ return;
+
+ // If, due to nesting of multiple gestures (e.g, from multiple touch
+ // devices), the beginning of the gesture has been lost, skip the remainder
+ // of the gesture.
+ if (!gestureBeginEvent_)
+ return;
+
+ // Send a GesturePinchBegin event if none has been sent yet.
+ if (!gestureBeginPinchSent_) {
+ WebGestureEvent beginEvent(*gestureBeginEvent_);
+ beginEvent.type = WebInputEvent::GesturePinchBegin;
+ renderWidgetHostView_->render_widget_host_->ForwardGestureEvent(beginEvent);
+ gestureBeginPinchSent_ = YES;
}
+
+ // Send a GesturePinchUpdate event.
+ const WebGestureEvent& updateEvent =
+ WebInputEventFactory::gestureEvent(event, self);
+ renderWidgetHostView_->render_widget_host_->ForwardGestureEvent(updateEvent);
}
- (void)viewWillMoveToWindow:(NSWindow*)newWindow {
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698