Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 886583004: [NaCl SDK] Allow dsc files to omit TOOLS setting (Closed)

Created:
5 years, 10 months ago by Sam Clegg
Modified:
5 years, 10 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Allow dsc files to omit TOOLS setting The default is to support all toolchains. Do this for several core libraries. This mostly affects mac for which these libraries were previously not being built. This change allows for the addition of nacl-clang or other toolchain without needing to change all the core dsc files. BUG=454962 Committed: https://crrev.com/4b386c1c9ea6286197c62a30d3aa800e7400a0c9 Cr-Commit-Position: refs/heads/master@{#314623}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -44 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 2 1 chunk +8 lines, -7 lines 0 comments Download
M native_client_sdk/src/build_tools/parse_dsc.py View 2 chunks +2 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 2 chunks +13 lines, -1 line 0 comments Download
M native_client_sdk/src/getting_started/part2/example.dsc View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/gmock/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/gtest/library.dsc View 2 chunks +0 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp_private/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_gles2/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/sdk_util/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/tools/common.mk View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/tools/host_gcc.mk View 1 2 3 4 6 chunks +20 lines, -11 lines 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 1 chunk +12 lines, -12 lines 0 comments Download
M native_client_sdk/src/tools/nacl_llvm.mk View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sam Clegg
5 years, 10 months ago (2015-02-03 22:25:34 UTC) #2
bradn
lgtm
5 years, 10 months ago (2015-02-04 10:41:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886583004/80001
5 years, 10 months ago (2015-02-04 19:31:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886583004/80001
5 years, 10 months ago (2015-02-04 20:35:08 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-04 20:36:41 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 20:37:43 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/4b386c1c9ea6286197c62a30d3aa800e7400a0c9
Cr-Commit-Position: refs/heads/master@{#314623}

Powered by Google App Engine
This is Rietveld 408576698