Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: native_client_sdk/src/build_tools/build_sdk.py

Issue 886583004: [NaCl SDK] Allow dsc files to omit TOOLS setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/parse_dsc.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/build_sdk.py
diff --git a/native_client_sdk/src/build_tools/build_sdk.py b/native_client_sdk/src/build_tools/build_sdk.py
index 503dda1840dd5fecef083e1afdaccf319d75979a..94276bf926066ede1a6b7425af0845ebd5fd4028 100755
--- a/native_client_sdk/src/build_tools/build_sdk.py
+++ b/native_client_sdk/src/build_tools/build_sdk.py
@@ -538,17 +538,18 @@ def GypNinjaBuild(arch, gyp_py_script, gyp_file, targets, out_dir):
gyp_defines.append('clang=1')
gyp_env['GYP_DEFINES'] = ' '.join(gyp_defines)
- for key in ['GYP_GENERATORS', 'GYP_DEFINES', 'CC']:
- value = gyp_env.get(key)
- if value is not None:
+ gyp_env['GYP_GENERATOR_FLAGS'] = 'output_dir=%s' % out_dir.replace('\\', '/')
+
+ # Print relevant environment variables
+ for key, value in gyp_env.iteritems():
+ if key.startswith('GYP') or key in ('CC',):
print '%s="%s"' % (key, value)
- gyp_generator_flags = ['-G', 'output_dir=%s' % (out_dir,)]
- gyp_depth = '--depth=.'
+
buildbot_common.Run(
- [sys.executable, gyp_py_script, gyp_file, gyp_depth] + \
- gyp_generator_flags,
+ [sys.executable, gyp_py_script, gyp_file, '--depth=.'],
cwd=SRC_DIR,
env=gyp_env)
+
NinjaBuild(targets, out_dir)
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/parse_dsc.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698