native_client_sdk/src/build_tools/parse_dsc.py - Issue 886583004: [NaCl SDK] Allow dsc files to omit TOOLS setting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/parse_dsc.py

Issue 886583004: [NaCl SDK] Allow dsc files to omit TOOLS setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/build_tools/parse_dsc.py

diff --git a/native_client_sdk/src/build_tools/parse_dsc.py b/native_client_sdk/src/build_tools/parse_dsc.py

index 5047469b1e8bdf2931dc56b1b83b4c79d5b60114..18cc722a444adc4b966f7e479d355d874cf2bd1d 100755

--- a/native_client_sdk/src/build_tools/parse_dsc.py

+++ b/native_client_sdk/src/build_tools/parse_dsc.py

@@ -28,7 +28,7 @@ DSC_FORMAT = {

# Don't generate the additional files to allow this project to run as a

# packaged app (i.e. manifest.json, background.js, etc.).

'NO_PACKAGE_FILES': (bool, [True, False], False),

- 'TOOLS' : (list, VALID_TOOLCHAINS, True),

+ 'TOOLS' : (list, VALID_TOOLCHAINS, False),

'CONFIGS' : (list, ['Debug', 'Release'], False),

'PREREQ' : (list, '', False),

'TARGETS' : (list, {

@@ -167,6 +167,7 @@ def LoadProject(filename):

return None

ValidateFormat(desc, DSC_FORMAT)

desc['FILEPATH'] = os.path.abspath(filename)

+ desc.setdefault('TOOLS', VALID_TOOLCHAINS)

return desc