components/favicon_base/BUILD.gn - Issue 886163003: [Favicon] Add FallbackIconStyle and FallbackIconService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon_base/BUILD.gn

Issue 886163003: [Favicon] Add FallbackIconStyle and FallbackIconService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment fix; moved FallbackIconStyle member functions outside of struct. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/favicon_base/BUILD.gn

diff --git a/components/favicon_base/BUILD.gn b/components/favicon_base/BUILD.gn

index d1e5a75a5dd512f2cb0b5619b90a2b274a049dac..71e8bc7367b36cc0b65f230d3c9e22d415995285 100644

--- a/components/favicon_base/BUILD.gn

+++ b/components/favicon_base/BUILD.gn

@@ -4,6 +4,10 @@

source_set("favicon_base") {

sources = [

+ "fallback_icon_service.cc",

+ "fallback_icon_service.h",

+ "fallback_icon_style.cc",

+ "fallback_icon_style.h",

"favicon_callback.h",

"favicon_types.cc",

"favicon_types.h",

« no previous file with comments | « components/favicon_base.gypi ('k') | components/favicon_base/DEPS » ('j') | components/favicon_base/fallback_icon_style.h » ('J')