Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: components/favicon_base.gypi

Issue 886163003: [Favicon] Add FallbackIconStyle and FallbackIconService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment fix; moved FallbackIconStyle member functions outside of struct. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/favicon_base/BUILD.gn » ('j') | components/favicon_base/fallback_icon_style.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon_base.gypi
diff --git a/components/favicon_base.gypi b/components/favicon_base.gypi
index 75210caf0d4768d74bca07f5924e45a2cd01463f..68ba1ec58dcefbce581a758b44741c98ba61a605 100644
--- a/components/favicon_base.gypi
+++ b/components/favicon_base.gypi
@@ -5,15 +5,24 @@
{
'targets': [
{
+ # GN version: //components/favicon_base
'target_name': 'favicon_base',
'type': 'static_library',
+ 'include_dirs': [
+ '..',
+ ],
'dependencies': [
'../base/base.gyp:base',
'../skia/skia.gyp:skia',
+ '../ui/base/ui_base.gyp:ui_base',
'../ui/gfx/gfx.gyp:gfx',
'../url/url.gyp:url_lib',
],
'sources': [
+ 'favicon_base/fallback_icon_service.cc',
+ 'favicon_base/fallback_icon_service.h',
+ 'favicon_base/fallback_icon_style.cc',
+ 'favicon_base/fallback_icon_style.h',
'favicon_base/favicon_callback.h',
'favicon_base/favicon_types.cc',
'favicon_base/favicon_types.h',
@@ -22,9 +31,6 @@
'favicon_base/select_favicon_frames.cc',
'favicon_base/select_favicon_frames.h',
],
- 'include_dirs': [
- '..',
- ],
},
],
}
« no previous file with comments | « no previous file | components/favicon_base/BUILD.gn » ('j') | components/favicon_base/fallback_icon_style.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698