Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: components/favicon_base/fallback_icon_style.h

Issue 886163003: [Favicon] Add FallbackIconStyle and FallbackIconService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment fix; moved FallbackIconStyle member functions outside of struct. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon_base/fallback_icon_service.cc ('k') | components/favicon_base/fallback_icon_style.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon_base/fallback_icon_style.h
diff --git a/components/favicon_base/fallback_icon_style.h b/components/favicon_base/fallback_icon_style.h
new file mode 100644
index 0000000000000000000000000000000000000000..097636b0ccb522aacb2af8aaa0612dfe70afe53d
--- /dev/null
+++ b/components/favicon_base/fallback_icon_style.h
@@ -0,0 +1,42 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_FAVICON_BASE_FALLBACK_ICON_STYLE_H_
+#define COMPONENTS_FAVICON_BASE_FALLBACK_ICON_STYLE_H_
+
+#include "third_party/skia/include/core/SkColor.h"
+
+namespace favicon_base {
+
+// Styling specifications of a fallback icon. The icon is composed of a solid
+// rounded square containing a single letter. The specification excludes the
+// icon URL and size, which are given when the icon is rendered.
+struct FallbackIconStyle {
+ FallbackIconStyle();
+ ~FallbackIconStyle();
+
+ // If any member changes, also update FallbackIconStyleBuilder.
+
+ // Icon background fill color.
+ SkColor background_color;
+
+ // Icon text color.
+ SkColor text_color;
+
+ // Ratio in [0.0, 1.0] of the text font size (pixels) to the icon size.
+ double font_size_ratio;
+
+ // The roundness of the icon's corners. 0 => square icon, 1 => circle icon.
+ double roundness;
+};
+
+// Reassigns |style|'s |text_color| to matches well against |background_color|.
+void MatchFallbackIconTextColorAgainstBackgroundColor(FallbackIconStyle* style);
+
+// Returns whether |style| values are within bounds.
+bool ValidateFallbackIconStyle(const FallbackIconStyle& style);
stevenjb 2015/02/11 21:15:58 FWIW I think this would have been better as a clas
huangs 2015/02/11 21:21:56 Acknowledged.
+
+} // namespace favicon_base
+
+#endif // COMPONENTS_FAVICON_BASE_FALLBACK_ICON_STYLE_H_
« no previous file with comments | « components/favicon_base/fallback_icon_service.cc ('k') | components/favicon_base/fallback_icon_style.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698