Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 885283009: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
James Hawkins
CC:
asanka, asvitkine+watch_chromium.org, benjhayden+dwatch_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, maniscalco+watch_chromium.org, marja+watch_chromium.org, maxbogue+watch_chromium.org, melevin+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, pvalenzuela+watch_chromium.org, rouslan+autofillwatch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=jhawkins@chromium.org Committed: https://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f Cr-Commit-Position: refs/heads/master@{#314468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -174 lines) Patch
M chrome/browser/autofill/android/personal_data_manager_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_platform_part_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_ui_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/google/google_search_counter_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/google/google_search_counter_android_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/history/android/android_cache_database_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/history/android/android_urls_database_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/android/sqlite_cursor_unittest.cc View 2 chunks +7 lines, -16 lines 0 comments Download
M chrome/browser/history/android/urls_sql_handler_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/history/android/visit_sql_handler_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/metrics/android_metrics_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager_basic.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/contextual_search_promo_source_android.h View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/search/search_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/in_memory_tab_restore_service.h View 1 chunk +19 lines, -20 lines 0 comments Download
M chrome/browser/signin/android_profile_oauth2_token_service.h View 2 chunks +16 lines, -20 lines 0 comments Download
M chrome/browser/signin/android_profile_oauth2_token_service.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/speech/tts_android.h View 2 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate_android.h View 1 chunk +20 lines, -20 lines 0 comments Download
M chrome/browser/sync/glue/synced_window_delegate_android.h View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:47:24 UTC) #1
James Hawkins
lgtm
5 years, 10 months ago (2015-02-04 00:48:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885283009/1
5 years, 10 months ago (2015-02-04 00:50:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 01:55:02 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 01:56:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f6a0230ed3693f0719938113a32a7f848112a9f
Cr-Commit-Position: refs/heads/master@{#314468}

Powered by Google App Engine
This is Rietveld 408576698