chrome/browser/history/android/android_history_provider_service_unittest.cc - Issue 885283009: Update {virtual,override,final} to follow C++11 style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/android/android_history_provider_service_unittest.cc

Issue 885283009: Update {virtual,override,final} to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/android/android_cache_database_unittest.cc ('k') | chrome/browser/history/android/android_urls_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/android/android_history_provider_service_unittest.cc

diff --git a/chrome/browser/history/android/android_history_provider_service_unittest.cc b/chrome/browser/history/android/android_history_provider_service_unittest.cc

index ca59252c5f69be9de97c9d6ca884c2772193314c..2fadfdc6120b5de4d11dedcc452bf29471c900d0 100644

--- a/chrome/browser/history/android/android_history_provider_service_unittest.cc

+++ b/chrome/browser/history/android/android_history_provider_service_unittest.cc

@@ -40,11 +40,10 @@ class AndroidHistoryProviderServiceTest : public testing::Test {

ui_thread_(BrowserThread::UI, &message_loop_),

file_thread_(BrowserThread::FILE, &message_loop_) {

}

- virtual ~AndroidHistoryProviderServiceTest() {

- }

+ ~AndroidHistoryProviderServiceTest() override {}

protected:

- virtual void SetUp() override {

+ void SetUp() override {

// Setup the testing profile, so the bookmark_model_sql_handler could

// get the bookmark model from it.

ASSERT_TRUE(profile_manager_.SetUp());

@@ -60,7 +59,7 @@ class AndroidHistoryProviderServiceTest : public testing::Test {

service_.reset(new AndroidHistoryProviderService(testing_profile_));

}

- virtual void TearDown() override {

+ void TearDown() override {

testing_profile_->DestroyHistoryService();

profile_manager_.DeleteTestingProfile(chrome::kInitialProfile);

testing_profile_=NULL;