chrome/browser/history/android/urls_sql_handler_unittest.cc - Issue 885283009: Update {virtual,override,final} to follow C++11 style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/android/urls_sql_handler_unittest.cc

Issue 885283009: Update {virtual,override,final} to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/android/sqlite_cursor_unittest.cc ('k') | chrome/browser/history/android/visit_sql_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/android/urls_sql_handler_unittest.cc

diff --git a/chrome/browser/history/android/urls_sql_handler_unittest.cc b/chrome/browser/history/android/urls_sql_handler_unittest.cc

index 2c92eca350905c94ee9f0d0e29cf5e847b7c0a02..623110b5ea70f33db122cf4579ddff1bd30bb6c7 100644

--- a/chrome/browser/history/android/urls_sql_handler_unittest.cc

+++ b/chrome/browser/history/android/urls_sql_handler_unittest.cc

@@ -26,10 +26,10 @@ class UrlsSQLHandlerTest : public testing::Test {

UrlsSQLHandlerTest()

: urls_sql_handler_(&history_db_),

visit_sql_handler_(&history_db_, &history_db_) {}

- virtual ~UrlsSQLHandlerTest() {}

+ ~UrlsSQLHandlerTest() override {}

protected:

- virtual void SetUp() {

+ void SetUp() override {

// Get a temporary directory for the test DB files.

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

base::FilePath history_db_name =

@@ -37,8 +37,7 @@ class UrlsSQLHandlerTest : public testing::Test {

ASSERT_EQ(sql::INIT_OK, history_db_.Init(history_db_name));

}

- virtual void TearDown() {

- }

+ void TearDown() override {}

TestHistoryDatabase history_db_;

base::ScopedTempDir temp_dir_;