Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 885183004: HTTPTransport: callers should be able to obtain the HTTP response body (Closed)

Created:
5 years, 10 months ago by Mark Mentovai
Modified:
5 years, 10 months ago
Reviewers:
Robert Sesek, scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

HTTPTransport: callers should be able to obtain the HTTP response body. This adds a new optional out-parameter to HTTPTransport::ExecuteSynchronously() and provides Mac and Windows implementations. BUG=crashpad:5 R=rsesek@chromium.org, scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/242619d9582f5ff28aa3ae177557f023e478140d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update comment #

Total comments: 1

Patch Set 3 : Update other comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -20 lines) Patch
M util/net/http_transport.h View 1 chunk +5 lines, -1 line 0 comments Download
M util/net/http_transport_mac.mm View 4 chunks +10 lines, -5 lines 0 comments Download
M util/net/http_transport_test.cc View 3 chunks +23 lines, -1 line 0 comments Download
M util/net/http_transport_test_server.py View 1 2 4 chunks +15 lines, -8 lines 0 comments Download
M util/net/http_transport_win.cc View 4 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mark Mentovai
5 years, 10 months ago (2015-02-05 21:41:59 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/885183004/diff/1/util/net/http_transport_test_server.py File util/net/http_transport_test_server.py (right): https://codereview.chromium.org/885183004/diff/1/util/net/http_transport_test_server.py#newcode21 util/net/http_transport_test_server.py:21: port the server is listening. It will then ...
5 years, 10 months ago (2015-02-05 21:46:12 UTC) #3
Mark Mentovai
Updated. Also waiting for Scott’s review for the Windows implementation.
5 years, 10 months ago (2015-02-05 22:28:41 UTC) #5
scottmg
lgtm https://codereview.chromium.org/885183004/diff/20001/util/net/http_transport_test_server.py File util/net/http_transport_test_server.py (right): https://codereview.chromium.org/885183004/diff/20001/util/net/http_transport_test_server.py#newcode142 util/net/http_transport_test_server.py:142: # process. comment out of date for "8s"
5 years, 10 months ago (2015-02-05 23:00:39 UTC) #6
Mark Mentovai
Thanks, updated.
5 years, 10 months ago (2015-02-05 23:03:59 UTC) #8
Mark Mentovai
5 years, 10 months ago (2015-02-05 23:05:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
242619d9582f5ff28aa3ae177557f023e478140d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698