HTTPTransport: callers should be able to obtain the HTTP response body

util/net/http_transport_mac.mm

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 98 matching lines @@
 
 namespace crashpad {
 
 namespace {
 
 class HTTPTransportMac final : public HTTPTransport {
  public:
   HTTPTransportMac();
   ~HTTPTransportMac() override;
 
-  bool ExecuteSynchronously() override;
+  bool ExecuteSynchronously(std::string* response_body) override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(HTTPTransportMac);
 };
 
 HTTPTransportMac::HTTPTransportMac() : HTTPTransport() {
 }
 
 HTTPTransportMac::~HTTPTransportMac() {
 }
 
-bool HTTPTransportMac::ExecuteSynchronously() {
+bool HTTPTransportMac::ExecuteSynchronously(std::string* response_body) {
   DCHECK(body_stream());
 
   @autoreleasepool {
     NSString* url_ns_string = base::SysUTF8ToNSString(url());
     NSURL* url = [NSURL URLWithString:url_ns_string];
     NSMutableURLRequest* request =
         [NSMutableURLRequest requestWithURL:url
                                 cachePolicy:NSURLRequestUseProtocolCachePolicy
                             timeoutInterval:timeout()];
     [request setHTTPMethod:base::SysUTF8ToNSString(method())];
 
     for (const auto& pair : headers()) {
       [request setValue:base::SysUTF8ToNSString(pair.second)
           forHTTPHeaderField:base::SysUTF8ToNSString(pair.first)];
     }
 
     base::scoped_nsobject<CrashpadHTTPBodyStreamTransport> transport(
         [[CrashpadHTTPBodyStreamTransport alloc] initWithBodyStream:
             body_stream()]);
     [request setHTTPBodyStream:transport.get()];
 
     NSURLResponse* response = nil;
     NSError* error = nil;
-    [NSURLConnection sendSynchronousRequest:request
-                          returningResponse:&response
-                                      error:&error];
+    NSData* body = [NSURLConnection sendSynchronousRequest:request
+                                         returningResponse:&response
+                                                     error:&error];
 
     if (error) {
       LOG(ERROR) << [[error localizedDescription] UTF8String] << " ("
                  << [[error domain] UTF8String] << " " << [error code] << ")";
       return false;
     }
     if (!response) {
       LOG(ERROR) << "no response";
       return false;
     }
     NSHTTPURLResponse* http_response =
         base::mac::ObjCCast<NSHTTPURLResponse>(response);
     if (!http_response) {
       LOG(ERROR) << "no http_response";
       return false;
     }
     NSInteger http_status = [http_response statusCode];
     if (http_status != 200) {
       LOG(ERROR) << base::StringPrintf("HTTP status %ld",
                                        implicit_cast<long>(http_status));
       return false;
     }
 
+    if (response_body) {
+      response_body->assign(static_cast<const char*>([body bytes]),
+                            [body length]);
+    }
+
     return true;
   }
 }
 
 }  // namespace
 
 // static
 scoped_ptr<HTTPTransport> HTTPTransport::Create() {
   return scoped_ptr<HTTPTransport>(new HTTPTransportMac());
 }
 
 }  // namespace crashpad