Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: util/net/http_transport.h

Issue 885183004: HTTPTransport: callers should be able to obtain the HTTP response body (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Update other comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/net/http_transport_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/net/http_transport.h
diff --git a/util/net/http_transport.h b/util/net/http_transport.h
index 554821535fad50ef6a22180848fb11d23ce74d33..333986a9772be4ad8338d31678d461cd4772eed3 100644
--- a/util/net/http_transport.h
+++ b/util/net/http_transport.h
@@ -74,9 +74,13 @@ class HTTPTransport {
//! \brief Performs the HTTP request with the configured parameters and waits
//! for the execution to complete.
//!
+ //! \param[out] response On success, this will be set to the HTTP response
+ //! body. This parameter is optional and may be set to `nullptr` if the
+ //! response body is not required.
+ //!
//! \return Whether or not the request was successful, defined as returning
//! a HTTP status 200 (OK) code.
- virtual bool ExecuteSynchronously() = 0;
+ virtual bool ExecuteSynchronously(std::string* response_body) = 0;
protected:
HTTPTransport();
« no previous file with comments | « no previous file | util/net/http_transport_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698