Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 884903003: [Extensions] Clean up some Permission[sData|Set] includes (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Clean up some Permission[sData|Set] includes Committed: https://crrev.com/a9ac53f0eb63f542044778f2bf0f96d5ea809f49 Cr-Commit-Position: refs/heads/master@{#315077}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -23 lines) Patch
M chrome/browser/extensions/permission_message_combinations_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/permissions/permission_set.h View 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/common/permissions/permission_set.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/common/permissions/permissions_data.h View 2 chunks +2 lines, -10 lines 0 comments Download
M extensions/common/permissions/permissions_data.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/shell/browser/media_capture_util.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
Nothing exciting, just in the area.
5 years, 10 months ago (2015-02-06 17:02:37 UTC) #3
not at google - send to devlin
lgtm
5 years, 10 months ago (2015-02-06 18:02:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884903003/20001
5 years, 10 months ago (2015-02-06 18:06:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-06 18:51:38 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 18:52:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9ac53f0eb63f542044778f2bf0f96d5ea809f49
Cr-Commit-Position: refs/heads/master@{#315077}

Powered by Google App Engine
This is Rietveld 408576698