extensions/common/permissions/permission_set.h - Issue 884903003: [Extensions] Clean up some Permission[sData|Set] includes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/permission_set.h

Issue 884903003: [Extensions] Clean up some Permission[sData|Set] includes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/permission_message_combinations_unittest.cc ('k') | extensions/common/permissions/permission_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/permission_set.h

diff --git a/extensions/common/permissions/permission_set.h b/extensions/common/permissions/permission_set.h

index 3afd799e9bd621360799831328b1997d4564675f..aee9cb9724f701ee228256a5844ec08e42e984ac 100644

--- a/extensions/common/permissions/permission_set.h

+++ b/extensions/common/permissions/permission_set.h

@@ -5,16 +5,11 @@

#ifndef EXTENSIONS_COMMON_PERMISSIONS_PERMISSION_SET_H_

#define EXTENSIONS_COMMON_PERMISSIONS_PERMISSION_SET_H_

-#include <map>

#include <set>

#include <string>

-#include <vector>

#include "base/gtest_prod_util.h"

#include "base/memory/ref_counted.h"

-#include "base/memory/singleton.h"

-#include "base/strings/string16.h"

-#include "extensions/common/manifest.h"

#include "extensions/common/permissions/api_permission.h"

#include "extensions/common/permissions/api_permission_set.h"

#include "extensions/common/permissions/manifest_permission.h"

@@ -22,7 +17,6 @@

#include "extensions/common/url_pattern_set.h"

namespace extensions {

-class Extension;

// The PermissionSet is an immutable class that encapsulates an

// extension's permissions. The class exposes set operations for combining and