Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: extensions/common/permissions/permissions_data.h

Issue 884903003: [Extensions] Clean up some Permission[sData|Set] includes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/permissions/permission_set.cc ('k') | extensions/common/permissions/permissions_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/permissions/permissions_data.h
diff --git a/extensions/common/permissions/permissions_data.h b/extensions/common/permissions/permissions_data.h
index ba2f3c3aa54078bbca0e1843e7fc2ec9942e3e70..138f476880d008f0a70dffbb846a9e8791f287a5 100644
--- a/extensions/common/permissions/permissions_data.h
+++ b/extensions/common/permissions/permissions_data.h
@@ -10,10 +10,8 @@
#include <vector>
#include "base/memory/ref_counted.h"
-#include "base/memory/scoped_ptr.h"
#include "base/strings/string16.h"
#include "base/synchronization/lock.h"
-#include "extensions/common/extension.h"
#include "extensions/common/manifest.h"
#include "extensions/common/permissions/api_permission.h"
#include "extensions/common/permissions/permission_message.h"
@@ -22,17 +20,11 @@
class GURL;
namespace extensions {
-
-class PermissionSet;
class Extension;
class URLPatternSet;
-class UserScript;
-// A container for the active permissions of an extension.
-// TODO(rdevlin.cronin): For the love of everything good, rename this class to
-// ActivePermissions. We do *not* need PermissionsParser, PermissionSet,
-// PermissionInfo, and PermissionsData. No one will be able to keep them
-// straight.
+// A container for the permissions state of an extension, including active,
+// withheld, and tab-specific permissions.
class PermissionsData {
public:
// The possible types of access for a given frame.
« no previous file with comments | « extensions/common/permissions/permission_set.cc ('k') | extensions/common/permissions/permissions_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698