Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 883613006: [turbofan] Cleanup the NodeProperties. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Cleanup the NodeProperties. R=svenpanne@chromium.org Committed: https://crrev.com/1df5fed50a4d318acf72b6ed0efb1533bc796b1f Cr-Commit-Position: refs/heads/master@{#26316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -334 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/change-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/control-reducer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/graph-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/graph-visualizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/load-elimination.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/loop-analysis.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/loop-peeling.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/node-properties.h View 1 chunk +92 lines, -40 lines 0 comments Download
M src/compiler/node-properties.cc View 2 chunks +180 lines, -1 line 0 comments Download
D src/compiler/node-properties-inl.h View 1 chunk +0 lines, -230 lines 0 comments Download
M src/compiler/representation-change.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/schedule.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/scheduler.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/control-equivalence-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/loop-peeling-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/node-properties-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 10 months ago (2015-01-29 08:44:58 UTC) #1
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-01-29 08:45:17 UTC) #2
Sven Panne
LGTM (mostly rubberstamped)
5 years, 10 months ago (2015-01-29 09:15:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883613006/1
5 years, 10 months ago (2015-01-29 09:16:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 09:17:55 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 09:18:21 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1df5fed50a4d318acf72b6ed0efb1533bc796b1f
Cr-Commit-Position: refs/heads/master@{#26316}

Powered by Google App Engine
This is Rietveld 408576698