Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 883393002: Remove Oilpan-specific clearing of DOMWindow during document detach. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove Oilpan-specific clearing of DOMWindow during document detach. Keep the observable lifetime of this object equal to what it is non-Oilpan. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look/consider. The clearing of the DOMWindow on document detach is an Oilpan ...
5 years, 10 months ago (2015-01-29 22:53:57 UTC) #2
haraken
LGTM. I think this change is safe.
5 years, 10 months ago (2015-01-30 09:46:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883393002/1
5 years, 10 months ago (2015-01-30 10:09:05 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 10:12:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189240

Powered by Google App Engine
This is Rietveld 408576698