Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 883393002: Remove Oilpan-specific clearing of DOMWindow during document detach. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 2167 matching lines...) Expand 10 before | Expand all | Expand 10 after
2178 // possible to re-attach. Eventually Document::detach() should be renamed, 2178 // possible to re-attach. Eventually Document::detach() should be renamed,
2179 // or this setting of the frame to 0 could be made explicit in each of the 2179 // or this setting of the frame to 0 could be made explicit in each of the
2180 // callers of Document::detach(). 2180 // callers of Document::detach().
2181 m_frame = nullptr; 2181 m_frame = nullptr;
2182 2182
2183 if (m_mediaQueryMatcher) 2183 if (m_mediaQueryMatcher)
2184 m_mediaQueryMatcher->documentDetached(); 2184 m_mediaQueryMatcher->documentDetached();
2185 2185
2186 lifecycleNotifier().notifyDocumentWasDetached(); 2186 lifecycleNotifier().notifyDocumentWasDetached();
2187 m_lifecycle.advanceTo(DocumentLifecycle::Stopped); 2187 m_lifecycle.advanceTo(DocumentLifecycle::Stopped);
2188 #if ENABLE(OILPAN)
2189 // Done with the window, explicitly clear to hasten its
2190 // destruction.
2191 clearDOMWindow();
2192 #endif
2193 2188
2194 // FIXME: Currently we call notifyContextDestroyed() only in 2189 // FIXME: Currently we call notifyContextDestroyed() only in
2195 // Document::detach(), which means that we don't call 2190 // Document::detach(), which means that we don't call
2196 // notifyContextDestroyed() for a document that doesn't get detached. 2191 // notifyContextDestroyed() for a document that doesn't get detached.
2197 // If such a document has any observer, the observer won't get 2192 // If such a document has any observer, the observer won't get
2198 // a contextDestroyed() notification. This can happen for a document 2193 // a contextDestroyed() notification. This can happen for a document
2199 // created by DOMImplementation::createDocument(). 2194 // created by DOMImplementation::createDocument().
2200 LifecycleContext<Document>::notifyContextDestroyed(); 2195 LifecycleContext<Document>::notifyContextDestroyed();
2201 ExecutionContext::notifyContextDestroyed(); 2196 ExecutionContext::notifyContextDestroyed();
2202 } 2197 }
(...skipping 3575 matching lines...) Expand 10 before | Expand all | Expand 10 after
5778 #ifndef NDEBUG 5773 #ifndef NDEBUG
5779 using namespace blink; 5774 using namespace blink;
5780 void showLiveDocumentInstances() 5775 void showLiveDocumentInstances()
5781 { 5776 {
5782 WeakDocumentSet& set = liveDocumentSet(); 5777 WeakDocumentSet& set = liveDocumentSet();
5783 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5778 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5784 for (Document* document : set) 5779 for (Document* document : set)
5785 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data()); 5780 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data());
5786 } 5781 }
5787 #endif 5782 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698