Source/core/dom/Document.cpp - Issue 883393002: Remove Oilpan-specific clearing of DOMWindow during document detach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 883393002: Remove Oilpan-specific clearing of DOMWindow during document detach. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index 0e4a46cdbf2df2c7fcd0c640f33d1b21906fa442..922487e26cebd25b1626c6c36508d8b54749d645 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -2185,11 +2185,6 @@ void Document::detach(const AttachContext& context)

lifecycleNotifier().notifyDocumentWasDetached();

m_lifecycle.advanceTo(DocumentLifecycle::Stopped);

-#if ENABLE(OILPAN)

- // Done with the window, explicitly clear to hasten its

- // destruction.

- clearDOMWindow();

-#endif

// FIXME: Currently we call notifyContextDestroyed() only in

// Document::detach(), which means that we don't call

« no previous file with comments | « no previous file | no next file » | no next file with comments »