Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 882443007: Remove unused hasLocalMatrix. (Closed)

Created:
5 years, 10 months ago by scroggo
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unused hasLocalMatrix. This method is not called anywhere on Android or Chrome, and it has a FIXME that it may not be correct. A client can still getLocalMatrix().isIdentity() if they need this information. (It has the same FIXME, and perhaps we should revisit it. In the meantime, this convenience method is not needed.) Committed: https://skia.googlesource.com/skia/+/5d2fd4465b270ec42d123202e50c33543f9c2083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M include/core/SkShader.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scroggo
5 years, 10 months ago (2015-01-30 14:26:03 UTC) #2
reed1
lgtm
5 years, 10 months ago (2015-01-30 14:36:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882443007/1
5 years, 10 months ago (2015-01-30 15:08:06 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 15:14:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5d2fd4465b270ec42d123202e50c33543f9c2083

Powered by Google App Engine
This is Rietveld 408576698