Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 882243002: [Extensions] Make extension actions use gfx::Image over gfx::ImageSkia. (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
Reviewers:
Finnur
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Make extension actions use gfx::Image over gfx::ImageSkia. gfx::Images cache different representations (such as NSImages), whereas gfx::ImageSkias (as a representation themselves) do not. Prefer to use gfx::Image in most icon code, so that these representations are cached. BUG=452971 Committed: https://crrev.com/bf734cdda75f3314996270eef0e924c63cac9743 Cr-Commit-Position: refs/heads/master@{#313768}

Patch Set 1 : With preceding patch #

Patch Set 2 : #

Patch Set 3 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -46 lines) Patch
M chrome/browser/extensions/api/declarative_content/content_action_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_action.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_action.cc View 1 7 chunks +15 lines, -18 lines 0 comments Download
M chrome/browser/extensions/extension_action_icon_factory.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_action_icon_factory.cc View 1 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_action_icon_factory_unittest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_action_storage_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/extension_icon_image.h View 1 3 chunks +6 lines, -0 lines 0 comments Download
M extensions/browser/extension_icon_image.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/browser/extension_icon_image_unittest.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
Hey Finnur, please take a look when you can. Follows https://codereview.chromium.org/885443004/ (ran trybots on first ...
5 years, 10 months ago (2015-01-29 01:12:02 UTC) #3
Finnur
LGTM
5 years, 10 months ago (2015-01-29 09:49:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882243002/60001
5 years, 10 months ago (2015-01-29 19:28:53 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 10 months ago (2015-01-29 20:04:25 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 20:06:10 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bf734cdda75f3314996270eef0e924c63cac9743
Cr-Commit-Position: refs/heads/master@{#313768}

Powered by Google App Engine
This is Rietveld 408576698